mchorse / mclib

Library mod for McHorse's mods
Other
24 stars 19 forks source link

Patches of Hacker‘s morph #29

Closed ghost closed 2 years ago

ghost commented 3 years ago

Main modifications:

All Mods: use UTF-8 encoding to read and save files

mchorse commented 3 years ago

Hey, thanks for all the PRs, but heads up that I'm going to release Mappet rc3 first before looking over these changes.

ghost commented 3 years ago

Got it. Before you come back to check out these changes, I may continue create some commits to fix bugs in my code or write some little features that pop into my head. Hope this doesn't disturb your break.

mchorse commented 3 years ago

Got it. Before you come back to check out these changes, I may continue create some commits to fix bugs in my code or write some little features that pop into my head. Hope this doesn't disturb your break.

Yeah, that's fine! Let me know when you'll finish it so I wouldn't merge this pull request before you're finished, though.

ghost commented 3 years ago

I just finished my last thought half a day ago and now there's nothing left in my brain XD Well, actually I'm not very sure if now is the right time to start the merge. Even though I've fixed many of my bugs, I'm still worried that there would be more. I guess I'm a bit nervous about the moment that will finally come.

ghost commented 3 years ago

Well, I was wrong. After a week of testing, it seems I still have work to do, and I apologize for that. I hope this doesn't interfere with your work schedule, and I'll let you know when I've finished these things.

mchorse commented 3 years ago

Well, I was wrong. After a week of testing, it seems I still have work to do, and I apologize for that. I hope this doesn't interfere with your work schedule, and I'll let you know when I've finished these things.

Yeah, that’s totally cool, there is no need to rush. I can accept PR any time. 👍