search

mchorse / metamorph

Morphing mod for Minecraft 1.12.2
Other
72 stars 42 forks source link

Prevent morph duplicates #291

Open Happ1ness-dev opened 2 years ago

Happ1ness-dev commented 2 years ago

Hello. Can you add the option (maybe in config) to prevent morph duplicates, when collecting the mob "soul", that you already have?

mchorse commented 2 years ago

Hello. Can you add the option (maybe in config) to prevent morph duplicates, when collecting the mob "soul", that you already have?

It’s already a thing, it’s just that some entities have have NBT data that constantly changes that creates unique NBT making it much harder to allow the system checking for duplicates to distinguish two morph entities as being the same when the data is mostly the same.

Happ1ness-dev commented 2 years ago

Hello. Can you add the option (maybe in config) to prevent morph duplicates, when collecting the mob "soul", that you already have?

It’s already a thing, it’s just that some entities have have NBT data that constantly changes that creates unique NBT making it much harder to allow the system checking for duplicates to distinguish two morph entities as being the same when the data is mostly the same.

Weird 🤔 I get a bunch of pig morphs after farming food.

mchorse commented 2 years ago

They have different Age: key, I think. If you’ll go to creative and in the creative morph menu, you’ll copy their NBT codes they would be different.

I’ve quit Minecraft modding, so don’t expect any fix. 😔

Chryfi commented 2 years ago

I already have enough on my todo list so I won't do it. I will leave this issue as open.