search

mchr3k / arduino-libs-manchester

172 stars 113 forks source link

Add support for Atmega8 #11

Closed bredita closed 11 years ago

bredita commented 11 years ago

I hope this can be useful.

mchr3k commented 11 years ago

Thanks for your contribution! I really appreciate you submitting the changes through GitHub.

bredita commented 11 years ago

You`re welcome. Thanks for maintaining/extending this library. VirtualWire was useless for me - long distance, cheap (almost useless) radios, but the manchester encoding made them work even in my very "polluted" environment (everyone has 433 MHz garage doors and other gadgets here).

Bredo

On May 13, 2013, at 10:12 PM, mchr3k notifications@github.com wrote:

Thanks for your contribution! I really appreciate you submitting the changes through GitHub.

— Reply to this email directly or view it on GitHub.

cano64 commented 11 years ago

I noticed you are assuming: (CS12 + CS11 set is, as far as I understand, equivalent to setting bit CS22 + CS21 on ATmega328.) but this is not true see http://www.atmel.com/Images/Atmel-2486-8-bit-AVR-microcontroller-ATmega8_L_datasheet.pdf page 99 and http://www.atmel.com/Images/doc8161.pdf page 162

but don't worry, I'm optimizing the counters and will have to fix it anyway, will pull request soon.

bredita commented 11 years ago

Thanks, As I said, I really don´t know what I´m doing. Appreciate all the help I can get :)

Bredo

On May 13, 2013, at 11:20 PM, Cano notifications@github.com wrote:

I noticed you are assuming: (CS12 + CS11 set is, as far as I understand, equivalent to setting bit CS22 + CS21 on ATmega328.) but this is not true see http://www.atmel.com/Images/Atmel-2486-8-bit-AVR-microcontroller-ATmega8_L_datasheet.pdf page 99 and http://www.atmel.com/Images/doc8161.pdf page 162

but don't worry, I'm optimizing the counters and will have to fix it anyway, will pull request soon.

— Reply to this email directly or view it on GitHub.