search

mchr3k / org.intrace

Java tracing agent and live trace client
http://mchr3k.github.com/org.intrace/
73 stars 18 forks source link

"exitStackTrace" and "gzip" enhancements together in a single pull request. #34

Closed eostermueller closed 10 years ago

eostermueller commented 10 years ago

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

image

mchr3k commented 10 years ago

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intrace exitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

  • M org.intrace/lib/intrace-agent.jarhttps://github.com/mchr3k/org.intrace/pull/34/files#diff-0(0)
  • M org.intrace/src/org/intrace/agent/AgentSettings.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-1(22)
  • M org.intrace/src/org/intrace/agent/ClassTransformer.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-2(10)
  • M org.intrace/src/org/intrace/agent/server/AgentClientConnection.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-3(6)
  • M org.intrace/src/org/intrace/client/gui/helper/ClientStrings.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-4(1)
  • M org.intrace/src/org/intrace/client/gui/helper/InTraceUI.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-5(25)
  • M org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-6(8)
  • M org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-7(22)
  • M org.intrace/src/org/intrace/output/NetworkDataSenderThread.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-8(5)
  • M org.intrace/src/org/intrace/output/trace/TraceHandler.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-9(52)
  • M org.intrace/src/org/intrace/output/trace/TraceSettings.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-10(25)
  • M org.intrace/src/org/intrace/shared/AgentConfigConstants.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-11(4)
  • A org.intrace/src/org/intrace/shared/Base64.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-12(2064)
  • M org.intrace/src/org/intrace/shared/TraceConfigConstants.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-13(2)
  • M org.intrace/testsrc/org/intracetest/agent/AgentTest.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-14(39)
  • A org.intrace/testsrc/org/intracetest/agent/CompressionTest.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-15(185)
  • A org.intrace/testsrc/org/intracetest/agent/StackTraceTest.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-16(63)
  • A org.intrace/testsrc/org/intracetest/agent/TraceSettingsTest.javahttps://github.com/mchr3k/org.intrace/pull/34/files#diff-17(53)

Patch Links:

eostermueller commented 10 years ago

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]< https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intrace exitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824 .

eostermueller commented 10 years ago

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]< https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intrace exitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824 .

mchr3k commented 10 years ago

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]< https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intrace exitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824 .

— Reply to this email directly or view it on GitHub.

mchr3k commented 10 years ago

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intrace exitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214 .

eostermueller commented 10 years ago

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old: https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752 .

mchr3k commented 10 years ago

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old: https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752 .

— Reply to this email directly or view it on GitHub.

mchr3k commented 10 years ago

OK this is fixed now. My build scripts didn't work exactly how I remembered :)

On 6 April 2014 13:22, Martin Hare Robertson mchr3k@gmail.com wrote:

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old:

https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller notifications@github.com wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/agent/server/AgentClientConnection.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-3>(6)

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752> .

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39666796 .

eostermueller commented 10 years ago

Looks good, thanks Martin.

On Sun, Apr 6, 2014 at 7:52 AM, mchr3k notifications@github.com wrote:

OK this is fixed now. My build scripts didn't work exactly how I remembered :)

On 6 April 2014 13:22, Martin Hare Robertson mchr3k@gmail.com wrote:

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old:

https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller <notifications@github.com

wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/agent/server/AgentClientConnection.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-3>(6)

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39666796> .

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39667572 .

mchr3k commented 10 years ago

Can you tell me anything more about what you are going to be presenting? Or can you send me your slides closer to the time?

On 7 Apr 2014, at 03:32, eostermueller notifications@github.com wrote:

Looks good, thanks Martin.

On Sun, Apr 6, 2014 at 7:52 AM, mchr3k notifications@github.com wrote:

OK this is fixed now. My build scripts didn't work exactly how I remembered :)

On 6 April 2014 13:22, Martin Hare Robertson mchr3k@gmail.com wrote:

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old:

https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller notifications@github.com wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k notifications@github.com wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller <notifications@github.com

wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

File Changes

org.intrace/src/org/intrace/agent/server/AgentClientConnection.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-3>(6)

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

Patch Links:

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39666796> .

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-39667572 .

— Reply to this email directly or view it on GitHub.

eostermueller commented 10 years ago

I'll send you a copy of my javaone submission in a week or so.

Hey, two other questions.

1) Would like your thoughts on my comments here: https://github.com/mchr3k/org.intrace/issues/31

2) Is the intrace server agent jar file available in a maven repo somewhere online? ...that sure would be helpful.

Thanks, --Erik

On Thu, Apr 10, 2014 at 11:18 AM, mchr3k notifications@github.com wrote:

Can you tell me anything more about what you are going to be presenting? Or can you send me your slides closer to the time?

On 7 Apr 2014, at 03:32, eostermueller notifications@github.com wrote:

Looks good, thanks Martin.

On Sun, Apr 6, 2014 at 7:52 AM, mchr3k notifications@github.com wrote:

OK this is fixed now. My build scripts didn't work exactly how I remembered :)

On 6 April 2014 13:22, Martin Hare Robertson mchr3k@gmail.com wrote:

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old:

https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release

InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller < notifications@github.com> wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k < notifications@github.com> wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller < notifications@github.com

wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

  • new [gzip-true parm will gzip traced message format on the wire
  • New UI checkbox enables user to capture stack trace of every 'exit' trace event. This is useful for troubleshooting like this:

http://johnsrandommusings.tumblr.com/post/33371606685/javadbb

File Changes

org.intrace/src/org/intrace/agent/server/AgentClientConnection.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-3>(6)

  • M

org.intrace/src/org/intrace/client/gui/helper/ClientStrings.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-4>(1)

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

org.intrace/testsrc/org/intracetest/agent/TraceSettingsTest.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-17>(53)

Patch Links:

Reply to this email directly or view it on GitHub<

https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824>

.

Reply to this email directly or view it on GitHub<

https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39666796> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39667572> .

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-40106016 .

mchr3k commented 10 years ago

1) I've pushed an implementation for this issue. 2) I'm not a maven user so InTrace is not in a maven repo. Feel free to publish a copy into your preferred repo :)

eostermueller commented 10 years ago

Martin,

I'll hear in mid June whether my proposal is accepted. What is the topic? Check out wuqiSpank.org.

Thanks for the intrace code that supports interfaces; I'll be giving it a test drive in the coming weeks.

--Erik

On Thu, Apr 10, 2014 at 11:18 AM, mchr3k notifications@github.com wrote:

Can you tell me anything more about what you are going to be presenting? Or can you send me your slides closer to the time?

On 7 Apr 2014, at 03:32, eostermueller notifications@github.com wrote:

Looks good, thanks Martin.

On Sun, Apr 6, 2014 at 7:52 AM, mchr3k notifications@github.com wrote:

OK this is fixed now. My build scripts didn't work exactly how I remembered :)

On 6 April 2014 13:22, Martin Hare Robertson mchr3k@gmail.com wrote:

I thought I updated both of these but has been a while since I did a release... I'll make sure these are fixed later today.

On 6 Apr 2014, at 13:13, eostermueller notifications@github.com wrote:

Thanks Martin, appreciate it. Could you also update the following page? http://mchr3k.github.io/org.intrace/download.html ...its pointing to old jar files.

Also, it would be helpful if you could do a mac release...or was I not looking in the right place?

The files in this mac tar are old:

https://github.com/mchr3k/org.intrace/tree/master/binaries/jars/latest_release

InTrace.app.tar

Thanks, --Erik

On Sat, Apr 5, 2014 at 6:12 PM, mchr3k notifications@github.com wrote:

I have now completed a release which includes these changes - thanks!

On 29 March 2014 16:55, Martin Hare Robertson mchr3k@gmail.com wrote:

Sure - I'll make sure I get a release done by then :)

On 29 Mar 2014, at 16:17, eostermueller < notifications@github.com> wrote:

Martin wrote:

but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

I would like to release an alpha version of my application around May 1 so I can present this at JavaOne and another CMG conference.

I'm not sure what your workload looks like, but could you make an InTrace release by then the my enhancements?

Thanks, --Erik

On Sun, Dec 8, 2013 at 7:53 PM, Erik Ostermueller eostermueller@gmail.comwrote:

Thanks, Martin, 'appreciate it. No immediate hurry, but would love to have them in base eventually.

Do you have any suggestions for how to implement this feature?

"Instrument all classes that implement this particular interface" I started out trying to modify ClassTransformer#isToBeConsideredForInstrumentation().

For some unknown reason, Class.isAssignableFrom() wouldn't work -- don't remember the exact error. I don't understand how it is implemented, but I could imagine that

  • ClassTransformer was part of the class loading process.
  • Calls to isAssignableFrom required the class-in-question to be fully loaded. Because the class was only partially loaded when I called, everything failed.

Let me know if you've got any suggestions.

Thanks, --Erik

--Erik

On Sun, Dec 8, 2013 at 6:56 PM, mchr3k < notifications@github.com> wrote:

Thanks for this pull request.

As you can see from my github repo I haven't done any work on InTrace in a while. I appreciate you putting these changes together but it may be a few weeks before I manage to find time to look at them and release a build which includes them.

On 8 December 2013 16:16, eostermueller < notifications@github.com

wrote:

As mentioned above, this pull request includes both the gzip and the exitStackTrace enhancements.

The following screenshot shows how to enable and view the stack trace that is appended to the exit event.

[image: image]<

https://f.cloud.github.com/assets/175773/1700598/e808a646-6023-11e3-8438-9266b1791dd9.png

You can merge this Pull Request by running

git pull https://github.com/eostermueller/org.intraceexitStackTrace

Or view, comment on, or merge it at:

https://github.com/mchr3k/org.intrace/pull/34 Commit Summary

  • new [gzip-true parm will gzip traced message format on the wire
  • New UI checkbox enables user to capture stack trace of every 'exit' trace event. This is useful for troubleshooting like this:

http://johnsrandommusings.tumblr.com/post/33371606685/javadbb

File Changes

org.intrace/src/org/intrace/agent/server/AgentClientConnection.java< https://github.com/mchr3k/org.intrace/pull/34/files#diff-3>(6)

  • M

org.intrace/src/org/intrace/client/gui/helper/ClientStrings.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-4>(1)

org.intrace/src/org/intrace/client/gui/helper/NetworkDataReceiverThread.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-6>(8)

  • M

org.intrace/src/org/intrace/client/gui/helper/ParsedSettingsData.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-7>(22)

org.intrace/testsrc/org/intracetest/agent/TraceSettingsTest.java<

https://github.com/mchr3k/org.intrace/pull/34/files#diff-17>(53)

Patch Links:

Reply to this email directly or view it on GitHub<

https://github.com/mchr3k/org.intrace/pull/34#issuecomment-30098824>

.

Reply to this email directly or view it on GitHub<

https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39000214>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39653752>

.

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39666796> .

Reply to this email directly or view it on GitHub< https://github.com/mchr3k/org.intrace/pull/34#issuecomment-39667572> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mchr3k/org.intrace/pull/34#issuecomment-40106016 .