Closed eostermueller closed 8 years ago
I forgot to mention this:
This breaks compatibility with previous versions.
Specifically,
Sorry for the delay, can you resolve the conflicts and then I'll accept the pull request? Thanks!
I'm sure it was my fault, but I couldn't find a way to update this pull request...never could tell which branch the changes resided on, so couldn't merge into that branch.
So I created a new branch in my downstream named 19and36. This is the combined changes of both original pull requests.
https://github.com/eostermueller/org.intrace/tree/19and36
Perhaps I should just create a new pull request for branch 19and36?
--Erik
Martin, the combined changes for issue 19 and issue 36 are now sitting on master of https://github.com/eostermueller/org.intrace.git.
Let me know if you need anything else.
--Erik
Martin,
I made a performance enhancement -- now using a chunkier wire format instead of the chatty one in Release 31. See results below for the improvements. Most of the changes are in NetworkDataSenderThread and NetworkDataReceiverThread and I've added junits that test/demonstrate the new process.
Would you apply the change to InTrace base? Thanks, --Erik
Some notes: