mchugh19 / zabbix-vue

Chrome/Firefox extension for displaying problems from Zabbix
MIT License
56 stars 13 forks source link

No colors in popup #24

Closed cstuder closed 4 years ago

cstuder commented 5 years ago

Starting today, Zabbix Vue doesn't show any colors in the popup:

image

Using Chrome 73 with Zabbix Vue 1.0.12.

I can't see anything in the commit log which might have triggered this.

(The Firefox Addons store is still offering Zabbix Vue 1.0.11 which still has colors.)

Tigerteron commented 5 years ago

Hi I have same problem, I reinstalled extension on chrome but problem not resolved

flunda commented 5 years ago

Hi,

same here. Since today. Also the default extension's icon is black instead of the color of the highest warning. Also the pop-ups are no longer working now. Chrome version Version 73.0.3683.86. Vue Version 1.0.12_0. Also tried reinstalling it and clearing data, but the issue still extists. Looks like there is some kind of incompatibility with the newes Chrome Version.

mchugh19 commented 5 years ago

Gah! Sorry all, I'll have to investigate this. The 1.0.12 release was forced by Google as Zabbix Vue had been pulled from the chrome store for an unspecified reason. It wasn't a fun process, but I managed to finally get someone to tell me what the issue was (they wanted a more detailed description).

So the only change the 1.0.12 should have included is updating that single line in the manifest, but I ended up having to setup and run the build on my windows laptop. I'm guessing it is very possible that something was very not happy about that environment or build process, so I'll take a look at rebuilding.

aceslup commented 5 years ago

same problem. Thank you for your shareing

mchugh19 commented 5 years ago

Hey all. Just pushed 1.0.13 to the chrome store. I've verified that it includes the proper colors and png support. Sorry for the bother.

flunda commented 5 years ago

Hey, thanks for pushing 1.0.13 - that fixed all my issues. Jut found out that i have to tick on the option for "allow in incognito mode" to get the popups working. Thanks a lot!

mchugh19 commented 5 years ago

@flunda I've been unable to replicate that issue. After restarting the browser do you still see that activity?

flunda commented 4 years ago

@mchugh19 Hi! Sorry for the belated reply, currently it seems we have an issue again. Since i have upgraded to the latest version of Google Chrome (Version 80.0.3987.87 - 64 bit) the Icon stays orange also when there are no issues in Zabbix (before the Icon was also green when no issues present in Zabbix). It seems that it is stuck on Orange, also when there are Issues indicating yellow, it is orange. Same for other colors (e.g. when it should be blue for information)

Can you please check?

thanks a lot flunda

mchugh19 commented 4 years ago

@flunda I've only seen these types of issues when the extension is freshly installed. Once chrome or Firefox are restarted, everything seems to work ok. Are you still seeing this behavior after a browser restart?

Tigerteron commented 4 years ago

I reinstall chrome and extension but nothing changed: 1-zabbix 4.4.4 2-Chrome 80 3-zabbix vue 1.14 Annotation 2020-02-12 065749

flunda commented 4 years ago

@mchugh19 Still seeing this behavior also after a restart of the browser and reboot of the PC. What is also strange, it stays black for about 4-5 seconds then it is turning to orange (but as you can see no issues currently present). When there are issues, the icon is showing them of course, but never changing it's color to the one with the highest priority. Always stays orange. image

flunda commented 4 years ago

@mchugh19 Update: i have removed the extension and added it back agin and now the icon stays black at all, but displaying all the issues, just not changing the color. Looks like the original issue.

image

mchugh19 commented 4 years ago

I'll keep playing around with this. So far I am unable to replicate.

Tigerteron commented 4 years ago

Dear Christian; one of my friends is developer is how extension to him and he fix by following changes: 1-convert all svg to png 2-change images in background.js for example: sev-1.svg convert to sev-1.png and change sev-1.svg to sev-1.png in background.js i tested two days an all things worked fine i hope this help to you

mchugh19 commented 4 years ago

Sounds like png images have better compatibility than svg. Just pushed a change to use png, and released this as 1.15. Please let me know if you continue to have problems.

flunda commented 4 years ago

@mchugh19 Thank you for fixing this. Could you please be so kind and push it also to Google Chome store so our Clients can install it directly from there?

thanks a lot

mchugh19 commented 4 years ago

@flunda yep, it's in the Google approval queue. Hopefully released soon!