mchung94 / solitaire-player

Automatically play Pyramid and TriPeaks Solitaire in Microsoft Solitaire Collection for Windows 10
MIT License
41 stars 14 forks source link

suggestion: --show-prompts, but only for duplicates #18

Open rmeden opened 2 years ago

rmeden commented 2 years ago

as many have said, thank you for this! I'm thinking of trying to write a Spider player, but it's been 20 years since I've ever coded anything this complicated (and don't really know java)! Should be a fun project once I get into it.

One suggestion... --show-prompts prompts you at the initial scan, any duplicates, and for permission to solve. I would like to see --show-error switch that only pops up when duplicates are detected so they can be corrected. This would make living with the Queen of Clubs issue easier. :)

mchung94 commented 2 years ago

I think that is a good idea! Thanks for the suggestion!

mchung94 commented 2 years ago

There's now a release with --show-error at https://github.com/mchung94/solitaire-player/releases/tag/v2.6.3 I made it just like you said, it's like --show-prompts but only shows the prompt if there's a problem like duplicate cards.

You can use it like: solitaire-player --show-error Pyramid

CaptBug commented 2 years ago

The --show-error option is very useful, but maybe it should be enabled by default? You could have a "--show-no-error" option instead if you wanted to.