MS Solitaire new version graphics changes

mchung94 / solitaire-player

Automatically play Pyramid and TriPeaks Solitaire in Microsoft Solitaire Collection for Windows 10

MIT License

41 stars 14 forks source link

MS Solitaire new version graphics changes #35

Closed cou94114 closed 1 year ago

cou94114 commented 1 year ago

Microsoft has released a new version of Solitaire. MS-Sol-version

The new version changes many of the screen graphics used by solitaire-player to identify items.

FreeCell execution results in "Can't detect if we're playing a game of FreeCell Solitaire."

Pyramid execution results in "Can't detect if we're playing a game of Pyramid Solitaire."

TriPeaks execution does work but the end of game graphic has changed. MS-Sol-TriPeaks-EOG-dialog-box

The bottom menu bar has changed. MS-Sol-TriPeaks-bottom-menu-bar

Microsoft has included a new Solver function in this version.

Thank you.

RobotManager commented 1 year ago

Another great bug report. Same problems here.

mchung94 commented 1 year ago

I finally got the updated version. I can push out an update that lets it work on FreeCell and Pyramid, but the No Moves Remaining problem on TriPeaks, I'll need to figure out something.

The main issue with the No Moves Remaining dialog box is that:

I want to avoid having the program look for the text like "No Moves Remaining" or "Undo last move" because there was a problem before where someone was using another language.
So the only image is that Key next to "Use Solver" - but that key is missing when the dialog says "Resume Solver" below
Also, I clicked on "Undo last move" and it actually turned on an advertisement, so my program got confused and tried to click on cards.

mchung94 commented 1 year ago

I've got a new release that may help: https://github.com/mchung94/solitaire-player/releases/download/v2.6.10/solitaire-player-v2.6.10.zip But it may still have issues with No Moves Remaining in TriPeaks.

RobotManager commented 1 year ago

Thank you! I've only given it a quick trial run, but so far so good. I appreciate your work on this and the speed of your response! :)

cou94114 commented 1 year ago

The new version does work for FreeCell and Pyramid. The new version does work with TriPeaks until it encounters the "No Moves Remaining" dialog box. I never realized that the reason for using the graphics and not text is due to alphabet differences. It makes sense, I just didn't connect the dots before.

It is ironic that a new feature of the game (Solver) can interfere with your program running successfully. It makes me wonder if a programmer (human or AI) at Microsoft analyzes your GitHub repository for solitaire-player and implements changes to cause you issues.

Thank you for your time and programming expertise.

cou94114 commented 1 year ago

I am closing this issue.

mchung94 commented 1 year ago

Thanks - I'll open an issue to figure out how to handle the "No Moves Remaining" problem. I think the least I can do is fall back on looking for the English text if I can't figure it out from an image, and if someone using a different language runs into the same problem, I can deal with it then.