search

mcib3d / mcib3d-plugins

ImageJ plugins for 3D processing and analysis
https://imagej.net/3D_ImageJ_Suite
8 stars 9 forks source link

slider UI elements appearance #15

Closed tischi closed 6 years ago

tischi commented 6 years ago

After running the 3D Image Suite the appearance of the sliders below the images is different. We feel that this does not really increase usability and for UI elements like the threshold adjustment it really makes it very difficult to use them:

image

Is there are reason that you want to change the UI slider element appearance?

imagejan commented 6 years ago

This might be caused by RoiManager3D_2.java changing the javax.swing Look-And-Feel here:

https://github.com/mcib3d/mcib3d-plugins/blob/c67e72e4b671a98e5a5daad48d54dd520e101b47/src/main/java/mcib_plugins/tools/RoiManager3D_2.java#L171-L197

I suggest not doing this, as it can mess up other components of ImageJ that are not properly using the Swing UI or making false assumptions about the width and height of UI elements in the standard look-and-feel.

mcib3d commented 6 years ago

Hi,

On my system (Linux) only the open file dialog is modified, not the thresholding window. Maybe best is to have this LooknFeel optional.

tischi commented 6 years ago

On my Mac it changes all UI elements that are opened afterwards. Making it optional (with default: "don't change", at least on Mac) sounds like a good idea, because also visitors that I am helping right now with image analysis told me that after using RoiManager_3D they basically always need to restart their Fiji :)

mcib3d commented 6 years ago

Fixed in 090254bc0b8c925e2972b998d645dd6933a98cc7

tischi commented 6 years ago

@mcib3d Thank you for fixing it! I think there is still one issue left: When clicking on [ 3D Segmentation ] in the 3D Roi Manager it still changes the UI mode: image