search

mcintyre321 / FormFactory

MVC5, Core or standalone - Generate rich HTML5 forms from your ViewModels, or build them programatically
http://formfactoryaspmvc.azurewebsites.net/
MIT License
304 stars 102 forks source link

Update to 4.6.1 #18

Closed patagoniahiker closed 7 years ago

patagoniahiker commented 8 years ago

Hi, can you please update to current 4.6.1 should be straight forward. thanks

skorunka commented 7 years ago

Package FormFactory.AspNetCore 2.0.112 is not compatible with net462, why?

mcintyre321 commented 7 years ago

The 4.5.1 version is for MVC5, the AspNetCore one is packaged for .NETStandard 1.6

Maybe there's a change to project.json you could suggest that would enable it?

skorunka commented 7 years ago

"The 4.5.1 version is for MVC5" that's not actually true. It is just a .NET 4.5.1 Framework. Unless your project is using a features the 451 does not have, why not to target this FW and allow other project to use your library without forcing them to upgrade to 461, 461 etc.?

For example, I'm working on Asp.NET Core MVC project and because FormFactory.AspNetCore targets "netstandard1.6" only I can not reference it in my project, as I target net462.

I believe, the only change you have to do is in "FormFactory.AspNetCore" project, file "project.json":

  "frameworks": {
    "netstandard1.6": {
      "imports": "dnxcore50"
    },
   "net451": {}
  }
mcintyre321 commented 7 years ago

Please, send a PR to this effect and I will merge it!

On 8 February 2017 at 15:01, Frantisek Skorunka notifications@github.com wrote:

"The 4.5.1 version is for MVC5" that's not actually true. It is just a .NET 4.5.1 Framework. Unless your project is using a features the 451 does not have, why not to target this FW and allow other project to use your library without forcing them to upgrade to 461, 461 etc.?

For example, I'm working on Asp.NET Core MVC project and because FormFactory.AspNetCore targets "netstandard1.6" only I can not reference it in my project, as I target net462.

I believe, the only change you have to do is in "FormFactory.AspNetCore" project, file "project.json":

"frameworks": { "netstandard1.6": { "imports": "dnxcore50" }, "net451": {} }

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/FormFactory/issues/18#issuecomment-278352225, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ0-tcoyjg7FWCL2Jk65UDAqPloTV47ks5radjfgaJpZM4HK3YB .

mcintyre321 commented 7 years ago

FF is now 451 and .NETCoreApp 1.1 compatible