search

mcintyre321 / FormFactory

MVC5, Core or standalone - Generate rich HTML5 forms from your ViewModels, or build them programatically
http://formfactoryaspmvc.azurewebsites.net/
MIT License
304 stars 102 forks source link

Localization #67

Closed frozenshadow closed 5 years ago

frozenshadow commented 6 years ago

Is there a possibility to translate/localize the validation messages (e.g. RequiredAttribute)?

mcintyre321 commented 6 years ago

You'd have to extend it yourself, but I'm happy to accept pull requests for any functionality like that. What approach for translation are you using, resx?

frozenshadow commented 6 years ago

Thanks for the quick reply. Currently I'm not using any translations yet, but I think I'll go for resx.

I don't have any experience with translating C# applications/websites, so that will be a challenge 😉 Once I got it working I will make a PR.

mcintyre321 commented 6 years ago

Are you doing asp.net MVC or asp.net core?

frozenshadow commented 6 years ago

asp.net MVC

frozenshadow commented 6 years ago

I made a working version for my project: https://github.com/frozenshadow/FormFactory. Since I've never made a (NuGet) package before, I don't know what the requirements are. So please let me know your thoughts ☺️

mcintyre321 commented 6 years ago

Does the asp.net core example work on your machine?

On Fri, 27 Jul 2018 at 14:23, frozenshadow notifications@github.com wrote:

I made a working version for my project: https://github.com/frozenshadow/FormFactory. Since I've never made a (NuGet) package before, I don't know what the requirements are. So please let me know your thoughts ☺️

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/FormFactory/issues/67#issuecomment-408417155, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ0-ni3joXapoYpuFHfIToXA7fsNU9gks5uKxRqgaJpZM4VjJx8 .

frozenshadow commented 6 years ago

No idea. Haven't tried, modified or used that one. I only customized it for my own project (a Enterprise solution).

mcintyre321 commented 6 years ago

It uses shared code from the main FormFactory project, so they both need to have been checked before I can pull the code into my repositoryy.

If you open your solution, and start each of the example projects, you should see the documentation site. If that works, I can safely merge the code, and then update the main FormFactory Nuget package.

frozenshadow commented 6 years ago

Ah, thanks for the guide. I’ll try and let you know next week.

And just realized I never thanked you for this awesome project. A true one-of-a-kind that really helped me a lot the past months. So a big THANK YOU!

mcintyre321 commented 6 years ago

Hey, thanks, that's great to hear!

I've got some ideas for FormFactory V2, but rarely get to chat to someone who's family. If you fancy jumping on slack sometime, let me know.

On Fri, 27 Jul 2018, 16:09 frozenshadow, notifications@github.com wrote:

Ah, thanks for the guide.

I’ll try and let you know next week.

And just realized I never thanked you for this awesome project.

A true one-of-a-kind that really helped me a lot the past months.

So a big THANK YOU!

Van: Harry McIntyre notifications@github.com Verzonden: vrijdag 27 juli 2018 16:58 Aan: mcintyre321/FormFactory FormFactory@noreply.github.com CC: frozenshadow contact@leijlandia.nl; Author < author@noreply.github.com> Onderwerp: Re: [mcintyre321/FormFactory] Localization (#67)

It uses shared code from the main FormFactory project, so they both need to have been checked before I can pull the code into my repositoryy.

If you open your solution, and start each of the example projects, you should see the documentation site. If that works, I can safely merge the code, and then update the main FormFactory Nuget package.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/mcintyre321/FormFactory/issues/67#issuecomment-408444463> , or mute the thread < https://github.com/notifications/unsubscribe-auth/AHIvQ2bdrM4UL2M6lUcYRqH7mwRVhlayks5uKyp_gaJpZM4VjJx8> . < https://github.com/notifications/beacon/AHIvQ3PCMZo0fUyGwQjdBacppVErFxD-ks5uKyp_gaJpZM4VjJx8.gif>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/FormFactory/issues/67#issuecomment-408447944, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ0-kp0XaUsoA4bYG2PyzryQHz9HRVtks5uKy1CgaJpZM4VjJx8 .

frozenshadow commented 6 years ago

Yeah sure, would love to!

I've just tested the MVC and Core examples. And it seems to be working ok. But just to be safe, maybe you should also check it ;)

mcintyre321 commented 6 years ago

I'm more a 'rollback if necessary' kinda guy :)

frozenshadow commented 6 years ago

Haha! You can sent me an invite for Slack if you want. My mail is on my profile page.