search

mcintyre321 / FormFactory

MVC5, Core or standalone - Generate rich HTML5 forms from your ViewModels, or build them programatically
http://formfactoryaspmvc.azurewebsites.net/
MIT License
304 stars 103 forks source link

EmbeddedFileProvider code example not compiling with .Net core 2.1 #78

Open Cannedfood opened 5 years ago

Cannedfood commented 5 years ago

With .Net core 2.1 the code in FormFactory.AspNetCore.Example/Startup.cs line 36 and 60 does not compile.

The EmbeddedFileProvider has to be created like this:

new EmbeddedFileProvider(typeof(FormFactory.FF).Assembly, nameof(FormFactory));

Maybe the example should be updated or the lines should be commented ("// For .Net core use bla")?

mcintyre321 commented 5 years ago

Cheers - I don't have a lot of time to work on FF, but I'd be very happy to merge a PR updating it all to a newer version of .NET Core

On Thu, 7 Mar 2019 at 09:10, Benno Straub notifications@github.com wrote:

With .Net core 2.1 the code in FormFactory.AspNetCore.Example/Startup.cs line 36 and 60 does not compile.

The EmbeddedFileProvider has to be created like this:

new EmbeddedFileProvider(typeof(FormFactory.FF).Assembly, nameof(FormFactory));

Maybe the example should be updated or the lines should be commented ("// For .Net core use bla")?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/FormFactory/issues/78, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ0-gG9Dmotl8u0vjUo-bgBDPze2MZNks5vUNeBgaJpZM4bisTm .