search

mcintyre321 / JsonDiffPatch

Apache License 2.0
50 stars 25 forks source link

Conflict with Tavis.JsonPointer library #9

Open fhucko opened 5 years ago

fhucko commented 5 years ago

We have project that references this library, and Tavis.JsonPointer library, and both libraries contain same class in same namespace. It would be nice if this library used the other library, or changed namespace of JsonPointer in this library. Currently we have to use reference alias + "extern alias" in code.

mcintyre321 commented 5 years ago

Which class?

On Thu, 20 Jun 2019, 08:22 hogan, notifications@github.com wrote:

We have project that references this library, and Tavis.JsonPointer library, and both libraries contain same class in same namespace. It would be nice if this library used the other library, or changed namespace of JsonPointer in this library. Currently we have to use reference alias + "extern alias" in code.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/JsonDiffPatch/issues/9?email_source=notifications&email_token=AACDJ6RPUCTUU2YGCL57Q3LP3MV47A5CNFSM4HZQGD3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2SRSFA, or mute the thread https://github.com/notifications/unsubscribe-auth/AACDJ6WLXLG5XVHRZO6IMRTP3MV47ANCNFSM4HZQGD3A .

fhucko commented 5 years ago

The only one in Tavis namespace in this library. Tavis.JsonPointer.

mcintyre321 commented 5 years ago

I'd be happy to accept a PR renaming the class/namespace, as long as a comment is included.

I'd prefer to reference Tavis.JsonPointer via nuget, but it seems there isn't a netstandard (non beta) package.

On Thu, 20 Jun 2019 at 09:19, hogan notifications@github.com wrote:

The only one in Tavis namespace in this library. Tavis.JsonPointer.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mcintyre321/JsonDiffPatch/issues/9?email_source=notifications&email_token=AACDJ6VNS2RI4M3XB5C5PHDP3M4SVA5CNFSM4HZQGD3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYEVHYY#issuecomment-503927779, or mute the thread https://github.com/notifications/unsubscribe-auth/AACDJ6T76QGXDWKN3CFG6A3P3M4SVANCNFSM4HZQGD3A .