Closed ducmvo closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
st-francis | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 9, 2023 3:42am |
It'd be nice to adjust spacing so vertical and horizontal spacing is equal between the buttons and borders. I realize this mistake comes from my code, but I think it'd be good to modify it here since this PR is redesigning these cards. Otherwise looks good to me
While on this topic, perhaps consider adjusting radii of elements since they're nested like this
https://cloudfour.com/thinks/the-math-behind-nesting-rounded-corners/
The vertical and horizontal spacing of the new text elements should also be adjusted to be equal, I think
interesting concept about the radii. Tried it with the button, but since the gap is large and the outer radius is small, the button radius become square. Doesn't look that good on this case. But will definitely apply for other stuff. Thanks for sharing!
fixed spacing issue
for the birthday, I think it's better in mm/dd/yyyy format that matches WA license/ID for faster comparison
Additional details and requirements were just provided in #52
Adjusted according to the extra requirements
Fixes #52