Make kedro unit test always run

l0uden commented 8 months ago

Description

test_get_action_callback_mapping.py::test_datasets_from_catalog unit test was skipped from running because kedro was not installed. Added kedro to the hatch env requirements. Also to make things identical I've added # pragma: no cov to the problematic lines in tests found by the coverage lib

Screenshot

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

antonymilne commented 7 months ago

I don't understand why this would be necessary given we have this already, which I think works ok?

matrix.python.features = [
  {value = "kedro", if = ["3.8", "3.9", "3.10", "3.11"]}
]

l0uden commented 7 months ago

I don't understand why this would be necessary given we have this already, which I think works ok?
matrix.python.features = [
  {value = "kedro", if = ["3.8", "3.9", "3.10", "3.11"]}
]

Yes, just forgot to close this draft, sorry. Discussed it last week

mckinsey / vizro