mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.61k stars 116 forks source link

Add unit tests for `Container` #265

Closed huong-li-nguyen closed 7 months ago

huong-li-nguyen commented 8 months ago

Description

Screenshot

Notice

petar-qb commented 7 months ago

petar-qb - do any tests have to be added regarding the actions code? Or is most of it covered by existing tests? Please also align with l0uden which ones we will cover in terms of unit tests and which ones l0uden should cover :) Thanks!

We'll probably need to add new unit tests for the newly added "search" helper methods, but let's wait for the final form of https://github.com/mckinsey/vizro/pull/254 and then I'll make these changes.

huong-li-nguyen commented 7 months ago

petar-qb - do any tests have to be added regarding the actions code? Or is most of it covered by existing tests? Please also align with l0uden which ones we will cover in terms of unit tests and which ones l0uden should cover :) Thanks!

We'll probably need to add new unit tests for the newly added "search" helper methods, but let's wait for the final form of #254 and then I'll make these changes.

Sounds good to me! 👍

I'll leave this PR open for you to wrap up then. In general, these PRs will be merged in this order to main:

  1. https://github.com/mckinsey/vizro/pull/254
  2. https://github.com/mckinsey/vizro/pull/262
  3. https://github.com/mckinsey/vizro/pull/265
petar-qb commented 7 months ago

@huong-li-nguyen With a small change made in the https://github.com/mckinsey/vizro/pull/265/commits/ad3f55b47f5924724e1f95e8fc580cbc500399ab, containers are fully tested with actions.

Unit tests for the newly added search helper methods in ModelManager have not yet been implemented as ModelManager will be completely overwritten soon (see https://github.com/mckinsey/vizro/issues/111).