calc(100%-Xpx) - had to replace percentage units with viewport height. I'll double-check with @pruthvip15 whether this is the right approach, but for now it fixes the issue and doesn't seem to affect the other browsers
@l0uden - this should fix the issue we've seen on Safari. Please double-check :)
@nadijagraca - important to be aware of above such that we always double-check and fix before merge
Screenshot
Before (on Safari)
Header was not visible
Screen was being cut-off and not scrollable
After
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.
Description
MarkUpSafe
dependency (as it was there only for pen-testing, but we don't use it anywhere anymore)The issues appeared on Safari because of two properties:
overflow: hidden
- for context see https://teamtreehouse.com/community/overflow-hidden-not-working-in-ios-safaricalc(100%-Xpx)
- had to replace percentage units with viewport height. I'll double-check with @pruthvip15 whether this is the right approach, but for now it fixes the issue and doesn't seem to affect the other browsers@l0uden - this should fix the issue we've seen on Safari. Please double-check :) @nadijagraca - important to be aware of above such that we always double-check and fix before merge
Screenshot
Before (on Safari)
After
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":