Closed Anna-Xiong closed 5 months ago
Hey @Anna-Xiong - thanks for tidying up - I always appreciate that!
Have some minor comments as I've just been reading through this code for the first time. Really up to you, whether you want to do a bit more refactoring while you're already on it, or if you just want to keep the PR as moving code to other files. I am fine either way 👍
It would help if the comments/todos have a bit more context? Just in case someone else would pick this up 😄
thank you Li! Most of this pr is to move helpers so that new pr can reuse those functions, but definitely worth addressing those comments while we can. i have addressed some of them and probably two of them need a bit more discussion/time to refine.
Description
Screenshot
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":