Closed l0uden closed 7 months ago
Hey @l0uden - thanks for this! Could you remind me what the next steps are and who needs to be involved?
I assume you need to reach out to Leon to allow the service user to bypass these protections. Anything else?
Hey @l0uden - thanks for this! Could you remind me what the next steps are and who needs to be involved?
I assume you need to reach out to Leon to allow the service user to bypass these protections. Anything else?
Hey @huong-li-nguyen
personal access token
for the service user, because it connected to his phone. If this user will have ability to merge to main
without extra permissions so that's it.
- did you test this?
Yes, I've tested it in the vizro-qa
repo. With the same settings and user.
- should we do this after every PR, not just the release?
I don't think that every merge to main should increase dev version. For example this PR do nothing to vizro library to increase even the dev version. Looking for changes in the specific folders also will not work, because we need to create changelog for every PR (but maybe there's a way to exclude changelog folder from scan somehow).
This looks great, thank you for figuring it all out! Just a minor tweak to the commit message would be nice.
Re @maxschulz-COL's idea of bumping on every push to main: we should not do this, since the same functionality already exists: each "build" of
main
is labelled by a git commit hash. It's already possible topip install
a specific commit directly. So effectively all we'd be doing is introducing some mapping from.devN
to git commit, but this would also introduce lots of noise in the commit history, and we should aim to keepmain
commit history reasonably clean.
I agree, but I was not referring to the ability to install a specific git commit, but rather to the ability to allow us/user to know precisely what version they actually have (if they install a different intermediate build).
I fully agree that this keep main unclean, and there is better solutions to it https://github.com/ofek/hatch-vcs. In fact I have tried the latter one back when I set this all up, but there was a known issue (that I think I documented in one of the PRs)
The above suggestion is essentially trying to emulate this.
I agree, but I was not referring to the ability to install a specific git commit, but rather to the ability to allow us/user to know precisely what version they actually have (if they install a different intermediate build).
I fully agree that this keep main unclean, and there is better solutions to it https://github.com/ofek/hatch-vcs. In fact I have tried the latter one back when I set this all up, but there was a known issue (that I think I documented in one of the PRs)
The above suggestion is essentially trying to emulate this.
Ah ok, that makes more sense. Overall I think this is too low value compared to the noise introduced in main
, since nthe number of users who install intermediate builds is very low (we should continue with our frequent releases to ensure this remains the case, and also feel free to bump the dev version manually whenever we like if we want to supply users with a particular unreleased version).
Description
I've changed the script for creating bump PR after the release to push the code directly to
main
branch.Personal access token
forvizro-svc
user was generated. It's stored inRepository secrets
asVIZRO_SVC_PAT
.Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":