Closed huong-li-nguyen closed 4 months ago
Are there any
dbc.Button
left in our codebase now apart from thevm.Button
itself?
No, there are no dbc.Buttons
anymore 👍 We just use it for the actual Button component and for the 404 landing page where there is an actual Button as well.
Description
dbc.Button
withdbc.Link
in Accordion, NavLink and NavBaractive_page_id
where possible (it's still present in some builds - see explanation here: https://github.com/mckinsey/vizro/pull/326#discussion_r1497505109)Context: Changes are necessary to ensure the use of semantically correct elements in the DOM, which is advantageous for HTML documents in general. This approach also proves beneficial when implementing a Bootstrap theme. Previously, the navigation erroneously adopted the primary button color when incorporating a Bootstrap theme. By utilizing the appropriate elements, we ensure that the correct coloring is applied based on the intended HTML element.
For our future selves to understand the decisions made here:
Screenshot
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":