mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.47k stars 109 forks source link

Tidy/actions to class #363

Open petar-qb opened 3 months ago

petar-qb commented 3 months ago

Description

For those who will review this PR:

Here is a small recommendation on how to familiarise yourself with the PR changes in the fastest way and how to review the PR. It is only a recommendation and feel free to skip some of the suggested steps if you are already familiar with them or if you are not interested in them.

  1. Don't rush to review the changes right away.
  2. Read the entire PR description.
  3. Watch the Team Learning session.
  4. Run all examples in vizro-core/examples/_dev/ folder. They are already sorted alphabetically in the way they should run. For each example: read file docstrings, explore application configuration, and run and play with application UI.
  5. Investigate CapturedActionCallable → useful Gist that @antonymilne made: https://gist.github.com/antonymilne/174c4c49ace2dae1f1d7674183b8d140 Link to the PS session -> https://mckinsey.box.com/s/fg1sdrpw6emprihhtg19ww4lft2ljma8
  6. Open and understand one of the action implementations (e.g. export_data_action)
  7. Search for TODO-AV2 and read everything. (especially since some "TODO-AV2" refer to multiple similar pieces of code, but are only written in one place)
  8. Start with discussing open questions ("TODO-AV2-OQ")
  9. Feel completely free to contribute:
    • Implementing some better architecture solutions,
    • Open any new kind of question.
    • Solving TODOs,
    • Cleaning the code,
    • Applying linting stuff,
    • Fixing/adding tests
    • Literally anything else
  10. Start with the standard code reviewing.

This PR is in the MVP phase because:

The most important changes:

Bugfixes:

TODO-AV2 legend:

PR TODOs:

Notice