Closed nadijagraca closed 6 months ago
Description
- Add validation similar to page.path to the card href property.
Issue solved: If user sets
page.path
with uppercase, space etc the validator will format it correctly. However, if user sets the same path ascard.href
it will lead to 404 page as card.href does not have validation. Now, any path that can be set inpage.path
can also be set ascard.href
.Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.
Hey @nadijagraca - not sure why you worked on this ticket as I've closed it a few days ago 😅 There was already a PR created as well, but we decided to not implement it: https://github.com/mckinsey/vizro/pull/348
I can explain in detail when I am back
Description
Issue solved: If user sets
page.path
with uppercase, space etc the validator will format it correctly. However, if user sets the same path ascard.href
it will lead to 404 page as card.href does not have validation. Now, any path that can be set inpage.path
can also be set ascard.href
.Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":