[Tidy] Replace `RadioItems` and `Checklist` - Githubissues

mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.

https://vizro.readthedocs.io/en/stable/

Apache License 2.0

2.46k stars 109 forks source link

[Tidy] Replace `RadioItems` and `Checklist` #414

Closed huong-li-nguyen closed 2 months ago

huong-li-nguyen commented 2 months ago

Description

Add new Bootstrap CSS file with RadioItems and Checklist added
Remove all custom CSS related to these two components
Refactor RadioItems and Checklist to use semantically correct Fieldset and Legend, for context see: https://accessibility.blog.gov.uk/2016/07/22/using-the-fieldset-and-legend-elements/
Remove redundant input-container class from selectors to consolidate gaps
Add another unit test for Card (for context: I broke it during this PR at some point, but there was no test covering it)

TO DO

[x] Tests are currently being fixed here: https://github.com/mckinsey/vizro-qa/pull/82
[ ] Minor refinements are still coming but that won't affect the core changes here, so this PR can be reviewed already

Screenshot

Run features demo dashboard:

Screenshot 2024-04-17 at 12 57 24

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.