mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.46k stars 109 forks source link

[QA] Ignore `pytest.PytestUnhandledThreadExceptionWarning` #425

Closed l0uden closed 2 months ago

l0uden commented 2 months ago

Description

Ignoring pytest.PytestUnhandledThreadExceptionWarning in the integration tests as it is flaky right now and this warning doesn't affect anything

Notice

l0uden commented 2 months ago

Do you think we need to investigate this further and actually fix it? Or do you think this is safe to ignore and is our long-term solution?

Depending on that could you add a ticket for any required follow-ups? 🙏

I think it is safe to ignore, because it is happening in the teardown of the test. So it's a long-term.

l0uden commented 2 months ago

This looks good!

Thanks for temporarily masking the annoying CI bug. We should probably get rid of this warning, but until then, it's fine to ignore it. 😄

I think it is not temp solution because this thing happens after test passed, on teardown. In our case we're not checking anything on this stage so can skip the warning