mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.46k stars 109 forks source link

[CI] Run `vizro-ai` integration tests on approval #454

Closed l0uden closed 1 month ago

l0uden commented 1 month ago

Description

Note:

Notice

l0uden commented 1 month ago

Is this fixing the issue now that tests only fail after merge? So now we can see it before? :)

Yes and no.

Now we have to approve it manually before merging. So everyone who will make changes to vizro_ai should keep in mind that this workflow should be approved and run before merging. It is the easiest and most convenient way to do it in monorepo.

huong-li-nguyen commented 1 month ago

Is this fixing the issue now that tests only fail after merge? So now we can see it before? :)

Yes and no.

Now we have to approve it manually before merging. So everyone who will make changes to vizro_ai should keep in mind that this workflow should be approved and run before merging. It is the easiest and most convenient way to do it in monorepo.

Can you just quickly mention this during stand-up today? 👍

l0uden commented 1 month ago

Is this fixing the issue now that tests only fail after merge? So now we can see it before? :)

Yes and no. Now we have to approve it manually before merging. So everyone who will make changes to vizro_ai should keep in mind that this workflow should be approved and run before merging. It is the easiest and most convenient way to do it in monorepo.

Can you just quickly mention this during stand-up today? 👍

Sure