mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.46k stars 109 forks source link

[Feat] Make dynamic data loading functions accept arguments #479

Closed antonymilne closed 1 month ago

antonymilne commented 1 month ago

Description

This is step 1 out of 2 in completing https://github.com/McK-Internal/vizro-internal/issues/753/ to allow for parametrisation of dynamic data from the frontend.

Here I just implement the changes needed to the data manager. I anticipated this would be as simple as adding *args, **kwargs in a couple of places, but it turned out to be much more complicated than that. In short:

Also I've written many more tests to check this all works. These are a bit slow because they run for many different functions and include time.sleep. If they become annoying to run in CI we can tag them as slow and split them out or skip them or something.

To do in this PR

To do in following PR #482

To do separately

Screenshot

Notice