[QA] Fix flaky `data_manager` unit tests - Githubissues

mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.

https://vizro.readthedocs.io/en/stable/

Apache License 2.0

2.63k stars 118 forks source link

[QA] Fix flaky `data_manager` unit tests #497

Closed petar-qb closed 4 months ago

petar-qb commented 4 months ago

Description

See issue for more.

Changes introduced in this PR:

deterministically solve the problem of unstable data_manager tests
speed-up data_manager unit tests a lot

Screenshot

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

petar-qb commented 4 months ago

@antonymilne thanks for taking the PR to a new level. I really like how the tests cases are now much more realistic (with timeouts of 300s and 100s). I agree with all your bullets from the comment above, but unfortunately I can't approve the PR I created 😄.