[Tidy] Consolidate usage of keyword `id` in unit tests - Githubissues

mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.

https://vizro.readthedocs.io/en/stable/

Apache License 2.0

2.63k stars 117 forks source link

[Tidy] Consolidate usage of keyword `id` in unit tests #500

Closed nadijagraca closed 3 months ago

nadijagraca commented 4 months ago

Description

Consolidate usage of id in tests

Screenshot

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

petar-qb commented 4 months ago

May you also update the id-s, children and such in the src (code) folder too?

I don't care much about the order of the component arguments, so it's up to you. All I'd like is that the ordering is aligned in the same (or similar) way across the entire vizro-core, and that we keep sending arguments as kwargs, rather than args.