mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.63k stars 117 forks source link

[Bug] Fix disappearance of charts after theme switch on mobile #511

Closed huong-li-nguyen closed 3 months ago

huong-li-nguyen commented 3 months ago

Description

Closes https://github.com/mckinsey/vizro/issues/508

Issue seems to be caused by two factors:

The current CSS fix forces the areas to always take on 100% height / width that's been allocated to them.

2024-06-03_16-15-48 (1)

Screenshot

Notice

nadijagraca commented 3 months ago

The changes look good to me, but I can't replicate the original issue.

Did you try to replicate it on mobile layout? I tried mobile layout in main, and charts were disappearing on theme switch.

petar-qb commented 3 months ago

Did you try to replicate it on mobile layout? I tried mobile layout in main, and charts were disappearing on theme switch.

Of course. I set the mobile dimensions exactly as they are in the original issue and ran the app from the main branch, but I couldn't replicate it. Anyway, if it works for you too, then let's merge this PR 😄.