[Bug] Fix duplicate figure display in jupyter notebook

[nadijagraca]

Description

Issue:

• duplicate figure is displayed when return_elements=False and the output is not assigned to a figure.

Possible combinations and outcomes (with merging this PR)	Configuration	explain	return_elements	Outcome
fig = vizro_ai.plot(...)	❌	❌	Fig not displayed, fig.show() needed
fig = vizro_ai.plot(...)	✅	❌	Fig not displayed, fig.show() needed, MD displayed
output_dataclass = vizro_ai.plot(...)	❌	✅	Fig not displayed, output_dataclass.figure.show() needed
output_dataclass = vizro_ai.plot(...)	✅	✅	Fig not displayed, output_dataclass.figure.show() needed, MD displayed
vizro_ai.plot(...)	❌	❌	Fig displayed
vizro_ai.plot(...)	✅	❌	Fig and MD displayed
vizro_ai.plot(...)	❌	✅	Fig not displayed, PlotOutputs printed
vizro_ai.plot(...)	✅	✅	Fig not displayed, MD and PlotOutputs displayed

Changes:

• removed adding fig.show() in the code
• assigned all plot outputs to a variable fig and added fig.show() in all examples in the docs

Screenshot

Notice

• [x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
  • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
  • I have not referenced individuals, products or companies in any commits, directly or indirectly.
  • I have not added data or restricted code in any commits, directly or indirectly.

[maxschulz-COL]

Configuration explain return_elements Outcome fig = vizro_ai.plot(...) ❌ ❌ Fig not displayed, fig.show() needed fig = vizro_ai.plot(...) ✅ ❌ Fig not displayed, fig.show() needed, MD displayed fig = vizro_ai.plot(...) ❌ ✅ Fig not displayed, fig.show() needed --> Incorrect? This would beed fig.figure.show()? fig = vizro_ai.plot(...) ✅ ✅ Fig not displayed, fig.show() needed, MD displayed --> Incorrect? This would beed fig.figure.show()? vizro_ai.plot(...) ❌ ❌ Fig displayed, MD and PlotOutputs printed --> Incorrect? Why would anything be printed? vizro_ai.plot(...) ✅ ❌ Fig and MD displayed vizro_ai.plot(...) ❌ ✅ Fig not displayed, PlotOutputs printed vizro_ai.plot(...) ✅ ✅ Fig not displayed, MD and PlotOutputs displayed --> MD displayed and PlotOutputs printed?

After our PS last week, this is what I expected? Do you agree @Anna-Xiong @nadijagraca ?

[maxschulz-COL]

Configuration explain return_elements Outcome fig = vizro_ai.plot(...) ❌ ❌ Fig not displayed, fig.show() needed fig = vizro_ai.plot(...) ✅ ❌ Fig not displayed, fig.show() needed, MD displayed fig = vizro_ai.plot(...) ❌ ✅ Fig not displayed, fig.show() needed --> Incorrect? This would beed fig.figure.show()? fig = vizro_ai.plot(...) ✅ ✅ Fig not displayed, fig.show() needed, MD displayed --> Incorrect? This would beed fig.figure.show()? vizro_ai.plot(...) ❌ ❌ Fig displayed, MD and PlotOutputs printed --> Incorrect? Why would anything be printed? vizro_ai.plot(...) ✅ ❌ Fig and MD displayed vizro_ai.plot(...) ❌ ✅ Fig not displayed, PlotOutputs printed vizro_ai.plot(...) ✅ ✅ Fig not displayed, MD and PlotOutputs displayed --> MD displayed and PlotOutputs printed?

After our PS last week, this is what I expected? Do you agree @Anna-Xiong @nadijagraca ?

@Anna-Xiong What I meant is that there are 4 cases in Nadjas description that are either wrong, or the actual behaviour is wrong. I was just thinking that you could clarify whether its just the description that is wrong, or the actual behaviour (look for the --> above)

[Anna-Xiong]

Hi @maxschulz-COL i think overall it aligns with what we discussed a week ago. Only minor difference is this one

Configuration	explain	return_elements	Outcome
vizro_ai.plot(...)	❌	❌	Fig displayed, MD and PlotOutputs printed

MD and PlotOutputs printed is not true here, but fig is displayed. Is there any particular case you observed to be different from what we discussed?