[Tidy] Improve `reference_format` of `kpi_card_reference` - Githubissues

mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.

https://vizro.readthedocs.io/en/stable/

Apache License 2.0

2.46k stars 109 forks source link

[Tidy] Improve `reference_format` of `kpi_card_reference` #549

Closed huong-li-nguyen closed 2 days ago

huong-li-nguyen commented 2 days ago

Description

Improve reference_format of kpi_card_reference by showing + sign in case positive delta

Screenshot

Screenshot 2024-06-26 at 16 50 31

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

huong-li-nguyen commented 2 days ago

Thanks for doing this! I wasn't sure if it was worth the effort but amazing that you just did it 😀

The docstring also needs to be updated and the screenshot in docs if you can be bothered but I don't mind if not.

Ups, I had auto-merge on 😄 I'll add that in in the next PR 👍