mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.73k stars 142 forks source link

Setting a default columnSize value for dash_ag_grid #681

Open petar-qb opened 2 months ago

petar-qb commented 2 months ago

Reference link: https://dash.plotly.com/dash-ag-grid/column-sizing#size-to-fit-and-responsive-size-to-fit

Should Vizro set columnSize="responsiveSizeToFit" for the dash_ag_grid figure function by default?

huong-li-nguyen commented 2 months ago

@maxschulz-COL and I once discussed this several times, but there were difficulties with each approach 😄 I actually don't remember what we ended up with.

So this is how I would expect it to work:

Now, I don't know what configuration achieves this (if any?)

maxschulz-COL commented 2 months ago

Mostly agree with the above. But I would note a few things:

huong-li-nguyen commented 2 months ago

I quickly discussed this with Joe and from a design perspective we would prefer that it expands to its full width (which it currently does not do). However, there are pros/cons for both approaches and the preference is not significant. So we decided to not change anything for now and let users configure it themselves 👍

This means for our demos, please set columnSize="responsiveSizeToFit" manually for now if the table does not take the full width :)