mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.72k stars 142 forks source link

[Demo] Add banner to visual vocabulary dashboard #868

Closed nadijagraca closed 1 week ago

nadijagraca commented 1 week ago

Description

Add banner to visual vocabulary dashboard

Screenshot

Screenshot 2024-11-12 at 13 49 00

Notice

github-actions[bot] commented 1 week ago

View the example dashboards of the current commit live on PyCafe :coffee: :rocket:

Updated on: 2024-11-13 10:57:15 UTC Commit: b9af5996dc573293ad09c8b47f48b804d4990766

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

huong-li-nguyen commented 1 week ago

Please don't merge yet. I'm trying out different designs and will push later :)

maxschulz-COL commented 1 week ago

My 5 cents :) : given this looks nice and is very non-intrusive, is it time to rethink whether this should be added permanenty to all apps? (similar to streamlit)

antonymilne commented 1 week ago

My 5 cents :) : given this looks nice and is very non-intrusive, is it time to rethink whether this should be added permanenty to all apps? (similar to streamlit)

IMO yes. My questions would be:

maxschulz-COL commented 1 week ago
  • should we have an option to turn it off (Dashboard.watermark = False)?

Not an easy question to answer given where we will move, hence answer to next question

  • should we save it for vizro 0.2.0 on the grounds that it's a somewhat disruptive/unexpected change? If we have an option to turn it off then I think probably not worth delaying.

Generally would have said no because FE design changes are no breaking changes, and I think we should adhere to that, but given that the above question is actually more far reaching we should think about it a bit more, thus waiting for 0.2.0 is probably not a bad idea

@Joseph-Perkins FYI

huong-li-nguyen commented 1 week ago

I discussed this with @Joseph-Perkins already and for now, we will only have it in our public demos. There are several design and UX considerations we would need to discuss first, which we can discuss offline 👍