Closed nadijagraca closed 1 week ago
Updated on: 2024-11-13 10:57:15 UTC Commit: b9af5996dc573293ad09c8b47f48b804d4990766
Link: vizro-core/examples/dev/
Link: vizro-core/examples/scratch_dev
Please don't merge yet. I'm trying out different designs and will push later :)
My 5 cents :) : given this looks nice and is very non-intrusive, is it time to rethink whether this should be added permanenty to all apps? (similar to streamlit)
My 5 cents :) : given this looks nice and is very non-intrusive, is it time to rethink whether this should be added permanenty to all apps? (similar to streamlit)
IMO yes. My questions would be:
Dashboard.watermark = False
)?
- should we have an option to turn it off (
Dashboard.watermark = False
)?
Not an easy question to answer given where we will move, hence answer to next question
- should we save it for vizro 0.2.0 on the grounds that it's a somewhat disruptive/unexpected change? If we have an option to turn it off then I think probably not worth delaying.
Generally would have said no because FE design changes are no breaking changes, and I think we should adhere to that, but given that the above question is actually more far reaching we should think about it a bit more, thus waiting for 0.2.0 is probably not a bad idea
@Joseph-Perkins FYI
I discussed this with @Joseph-Perkins already and for now, we will only have it in our public demos. There are several design and UX considerations we would need to discuss first, which we can discuss offline 👍
Description
Add banner to visual vocabulary dashboard
Screenshot
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":