Open l0uden opened 1 week ago
Updated on: 2024-11-25 15:29:21 UTC Commit: 335fd21a192d70ed721735f2fcb00743e4655487
Link: vizro-core/examples/dev/
Link: vizro-core/examples/scratch_dev
@antonymilne , thanks for the very useful review comments! I've fixed them all without comments under your reviews, but left answers were it was most important.
@antonymilne , finished with your latest suggestions
Looks good to me, thanks also for A to make such a thorough review before. I didn't write down any comment, but I think the
e2e_asserts.py
would benefit from a few inline code comments about what you are doing. Since not everyone will be super familiar withcv2
etc, it is sometime hard to guess what even the overall strategy is. Maybe a few comments guide a reader on what the code is doing might be helpful?
Left comments about cv2
logic
All your comment are now addressed, thanks!
Description
Moved component library tests from vizro-qa
Notice
[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":