mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.72k stars 142 forks source link

[QA] Component library tests #872

Open l0uden opened 1 week ago

l0uden commented 1 week ago

Description

Moved component library tests from vizro-qa

Notice

github-actions[bot] commented 1 week ago

View the example dashboards of the current commit live on PyCafe :coffee: :rocket:

Updated on: 2024-11-25 15:29:21 UTC Commit: 335fd21a192d70ed721735f2fcb00743e4655487

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

l0uden commented 5 days ago

@antonymilne , thanks for the very useful review comments! I've fixed them all without comments under your reviews, but left answers were it was most important.

l0uden commented 5 days ago

@antonymilne , finished with your latest suggestions

l0uden commented 15 hours ago

Looks good to me, thanks also for A to make such a thorough review before. I didn't write down any comment, but I think the e2e_asserts.py would benefit from a few inline code comments about what you are doing. Since not everyone will be super familiar with cv2 etc, it is sometime hard to guess what even the overall strategy is. Maybe a few comments guide a reader on what the code is doing might be helpful?

Left comments about cv2 logic

All your comment are now addressed, thanks!