mckinsey / vizro

Vizro is a toolkit for creating modular data visualization applications.
https://vizro.readthedocs.io/en/stable/
Apache License 2.0
2.72k stars 142 forks source link

[Tidy] Remove all CSS variables and tokens #886

Open huong-li-nguyen opened 6 days ago

huong-li-nguyen commented 6 days ago

Description

For Developers:

For any upcoming CSS modifications, please use the CSS variables from vizro-bootstrap.min.css. Your code editor should offer autocompletion so you can see the available options. Avoid using any outdated variables/tokens.

Impact on Demos:

Be aware that all demos using custom CSS and previously relying on our static folder's CSS variables/tokens will be affected. This primarily impacts our internal demos, though there is a slight possibility it could affect a user demo (e.g. if we provided them with custom CSS snippets that used our variables/tokens).

To update our demos, we need to merge this PR first and then release vizro. Following this, we can merge this upcoming PR and update the vizro version accordingly.

Screenshot

Notice

github-actions[bot] commented 6 days ago

View the example dashboards of the current commit live on PyCafe :coffee: :rocket:

Updated on: 2024-11-25 17:16:23 UTC Commit: 7b3e2e352c849cb1adb6be01c94ddb7bda6585a0

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

huong-li-nguyen commented 22 hours ago

I didn't actually try anything out but I trust our screenshot tests to catch if anything is wrong.

I had to update some of them as well 😄 But don't worry, I went through min. 10-15 rounds of screenshot comparisons to check where the difference lies. Some of our token values have changed in the QB design library, but that change didn't go through to Vizro because our tokens don't automatically update 👍