search

mcknly / breadboard-os

A firmware platform aimed at quick prototyping, built around FreeRTOS and a feature-packed CLI
MIT License
500 stars 19 forks source link

add_definition -DUSING_PICOW if board is pico_w #13

Closed fatdollar closed 2 weeks ago

fatdollar commented 2 weeks ago 
-libraries now have the definition as well
fatdollar commented 2 weeks ago

Here is a fix that addresses the pico_w issue. I have never done a pull request with Github before so if I have not done this correctly let me know.

Basically from what I found out because cli and other directories were being added as a library the definition that was in the hardware_build_extra function was not being propagated to them. So I added a conditional to the file that added the libraries and now the -DUSING_PICOW is being passed to all files.

I'm open to suggestions if this is not seen as the best way to fix the issue. And if I need to open the pull request a different way then let me know.

Thanks.

fatdollar commented 2 weeks ago

That's a good call.

I just amended my commit and made that change in hardware/rp2040/CMakeList.txt instead.

Probably want to do more testing but It looks like the -DUSING_PICOW is included in all of the files need at this point. I've attached the build output for review if needed. It runs on my Pico_W and the led option is still absent as it should be.

Let me know if you need anything else.

build_target.txt