search

mcktr / check_fritz

Check plugin written in Go to monitor a Fritz!Box
GNU General Public License v2.0
32 stars 10 forks source link

No WARNING or CRITICAL status for device and connection status #108

Open Pentidumm opened 3 years ago

Pentidumm commented 3 years ago

Hi, this is my first GitHub issue. Sorry if I did do something wrong.

The methods connection_uptime and device_uptime always return OK. Since I want to monitor the status, I need Warning and Critical also.

Example for connection_uptime: $ ./check_fritz -p <password> -m connection_uptime -w 252000 -c 259200 OK - Connection Uptime: 252765 seconds (2d 22h 12m 45s) | 'uptime'=252765.000000s;;;;

Expected output: CRITICAL - Connection Uptime: 252765 seconds (2d 22h 12m 45s) | 'uptime'=252765.000000s;252000.000000s;259200.000000s;;

Am I doing something wrong here or is this a check plugin bug?

mcktr commented 3 years ago

Hi,

thanks for creating this issue, you did everything right! :-)

Indeed, for the uptime checks there is currently no warning and critical thresholds implemented. I plan to implement them in a future version, they are highly likely coming with an overhaul for the thresholds which will also implement ranges, see #101.

I'll keep this issue open for visibility.

Best regards Michael.