mcktr / check_fritz

Check plugin written in Go to monitor a Fritz!Box
GNU General Public License v2.0
32 stars 10 forks source link

Support for the Fritz!Box cable versions #40

Closed mcktr closed 5 years ago

mcktr commented 5 years ago

Implement support for the Fritz!Box cable versions. The only methods where this matters should be the method where we check the link connection (connection_status, connection_uptime).

While the implementation should be fairly easy, the testing is difficult since I don't have a Fritz!Box cable version at hand.

uclara commented 5 years ago

Hi mcktr, I was a bit scared seeing that you stopped the development of check_tr64_fritz. But I'm very appreciate your move to GOLANG :-) As for check_tr64_fritz I also would support you for testing the Cable box.

Ulli

mcktr commented 5 years ago

Hi @uclara,

thanks for the offer, I highly appreciate this. :+1:

I now released a new release candidate version with the latest features, including support for Fritz!Box cable models.

Can you please test v1.1.0-rc1? :-)

Ensure you add --modelgroup "Cable" to the check call:

./check_fritz --hostname "192.168.178.1" --password "password" --modelgroup "Cable"

Please test the --modelgroup parameter with the two check methods connection_status and connection_uptime.

Thank you!

uclara commented 5 years ago

Hi @mcktr,

it seems working fine on my FRITZ!Box 6490 Cable :-)

Ulli

mcktr commented 5 years ago

@uclara Thanks for testing :+1: