mcktr / check_tr64_fritz

Icinga 2 Plugin to check a Fritz!Box
GNU General Public License v2.0
30 stars 10 forks source link

Investigate the warning behavior of the update check #51

Closed mcktr closed 6 years ago

mcktr commented 6 years ago

The update check often returns a warning state but no update is available.

The check returns the following output:

WARNING - Update State: Stopped

I guess the update mechanism on the FritzBox itself only run in a certain interval and between a restart and the first run of the update mechanism the state is stopped. But this needs further investigation.

But imho the warning state is wrong here, unknown would be better.

mcktr commented 6 years ago

After triggering a update search on the FritzBox, the state switch to "NoUpdate" which returns OK,

mcktr commented 6 years ago

Reading through the AVM doc here: https://avm.de/fileadmin/user_upload/Global/Service/Schnittstellen/userifSCPD.pdf

I found out that the check update function maybe checks the wrong attribute. What it should check is if there is an update or not, but now the function checks if the update mechanism is running (?).

The correct attribute would be NewUpgradeAvailable

mcktr commented 6 years ago

Fixed in #52