search

mclaeysb / simplepolygon

JS tool to break self-intersecting GeoJSON polygons down in their constituent non-self-intersecting parts
MIT License
82 stars 11 forks source link

allIsectsAsIsectRbushTreeItem is not declared #14

Closed ffflabs closed 7 years ago

ffflabs commented 7 years ago

@mclaeysb

In line https://github.com/mclaeysb/simplepolygon/blob/23030c354ed3cc550bb0f1caec92a95d88842695/index.js#L105

Variable allIsectsAsIsectRbushTreeItem isn't declared as var, let or const.

In some environments this amounts for the variable becoming global. Linters complain about it being undeclared, and QUnit doesn't pass tests if

QUnit.config.noglobals = true; config option is used.

Do you think you could declare this variable without side effects?

mclaeysb commented 7 years ago

Yes, we could. Please submit a PR, I'll happily accept it!

ffflabs commented 7 years ago

I've created it #15

mclaeysb commented 7 years ago

Solved by #15, closing!