Upgraded GU10's from 3.42 -> 3.60 firmware, now can't be discovered

mclarkk / lifxlan

Python library for accessing LIFX devices locally using the official LIFX LAN protocol.

MIT License

503 stars 115 forks source link

Upgraded GU10's from 3.42 -> 3.60 firmware, now can't be discovered #146

Closed ps-jay closed 4 years ago

ps-jay commented 4 years ago

Hi all,

Two of my GU10's upgraded from 3.42 firmware to 3.60, and now get_devices() fails to discover them. I still have one GU10 on the 3.41 firmware, and it can be discovered.

Has anyone experienced this? Is it related to #138 ?

I'm happy to contribute code if someone can give me pointers on how to troubleshoot.

Regards, Phil

ps-jay commented 4 years ago

Hi again,

it looks to me like the 3.60 firmware does not like the source_id being set to 1.

If I alter self.source_id to be hardcoded to value for example, then I can discover 3.60 firmware GU10's.

I'm running LifxLAN in a Docker container, so the os.getpid() method is returning 1 - triggering the issue.

I'll raise a PR in the next few days to address this.

mclarkk commented 4 years ago

Great discovery! I'll take a look at the PR shortly.

ps-jay commented 4 years ago

Closed via #148