search

mclear-tools / tabspaces

GNU General Public License v3.0
226 stars 14 forks source link

Unusable `tabspaces-open-or-create-project-and-workspace` #42

Closed abougouffa closed 11 months ago

abougouffa commented 11 months ago

Hello and thank you for your responsiveness on issue #38

The commit e93774372b8e860a9cb092b27a4ae3c482323608 broke the workflow! Now, calling tabspaces-open-or-create-project-and-workspace on existing projects asks each time for repo initialization as Git, Hg, ...

Also, the tabspaces--generate-unique-tab-name function causes opening the same project twice to create two tabs with names "project" and "project<1>".

I think the commit should be revoked until this gets fixed, in my config, I'm explicitly using the commit before this one.

I will try to work on this the next weekend and open a PR.

Thank you again for this awesome package!

mclearc commented 11 months ago

Ah -- ok now I think I see the problem. I'll look into it.

Note though that the duplicate tab function is a feature not a bug. Some folks might want two different workspaces for the same project.

mclearc commented 11 months ago

Turns out this was just a dumb error on my part -- I had duplicated the function erroneously.

abougouffa commented 11 months ago

Thank you for the quick response, I've noticed and fixed it, but you were much faster! Thanks again!