Closed folken88 closed 2 years ago
mclemente
commented
2 years ago I see the problem, both the system and the module try to patch the same core function (ChatLog.parse).
As of right now, the fix would be a bit weird: I'd have to write down the original function and then patch PF1's patch. It's doable, but it isn't ideal. I'll try to get the PF1 devs to change how they store the original function so Advanced Macros can patch it without conflicting with their own patching.
mclemente
commented
2 years ago Hello, could you try updating Advanced Macros to version 1.14.3 and check if it is working properly now?
folken88
commented
2 years ago IT IS WORKING. THANK YOU THANK YOU. Do you have a patreon? I'm a paid GM and I typically only sub to artists but truly dude, THIS MOD is the only mod that is required. I have blind players and ONLY YOUR MOD matters. I write macros for every skill, spell, attack, and check my blind players have so they can just type /per for perception, /mm for magic missile, etc. Without your mod, they cannot control their characters. With your mod, the blind players are not only equal to the sighted folks, they are then better (bc blind people have amazing memories) than average players.
Thank you so very much for your work. It is SO appreciated.
-Toby
On Mon, Jun 20, 2022 at 3:05 PM Matheus Clemente @.***> wrote:
Hello, could you try updating Advanced Macros to version 1.14.3 and check if it is working properly now?
— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros/issues/30#issuecomment-1160805915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTEMIAM533VA4CSMW7DVQDFHZANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-advanced-macros/issues/30/1160805915@ github.com>
mclemente
commented
2 years ago Thank you, it warms my heart to read this! It never crossed my mind this brought accessibility for blind people.
I don't have a Patreon since my modules don't have constant updates or new features. I do have a Ko-fi for donations, though: https://ko-fi.com/mclemente
I'm closing this issue as resolved.
folken88
commented
2 years ago Yep, your mod makes online tabletop gaming possible for people with bad or no eyesight. Now if only someone will write a mod that does text-to-speech for the blind players rolls (only). ;D
-T
On Tue, Jun 21, 2022 at 11:00 PM Matheus Clemente @.***> wrote:
Thank you, it warms my heart to read this! It never crossed my mind this brought accessibility for blind people.
I don't have a Patreon since my modules don't have constant updates or new features. I do have a Ko-fi for donations, though: https://ko-fi.com/mclemente
I'm closing this issue as resolved.
— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros/issues/30#issuecomment-1162610437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTE54MMIW6TK73CBOZDVQKFW3ANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-advanced-macros/issues/30/1162610437@ github.com>
mclemente
commented
2 years ago Hello, I just updated Advanced Macros' chat messages to fix another issue that came up. As far as I've tested, the changes didn't affect PF1 at all, but, if anything comes up on version 1.17, be sure to tell me.
folken88
commented
2 years ago Works great! Everything but saves rolls with skipdialogue and the cursor stays in chat. I tested skills, spells, items, and saves.
Thank you so much for your work on this mod!
On Tue, Sep 27, 2022 at 2:06 PM Matheus Clemente @.***> wrote:
Hello, I just updated Advanced Macros' chat messages to fix another issue that came up. As far as I've tested, the changes didn't affect PF1 at all, but, if anything comes up on version 1.17, be sure to tell me.
— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros/issues/30#issuecomment-1259932479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTGP2A4TJBCBJNPMHJDWANASTANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-advanced-macros/issues/30/1259932479@ github.com>
mclemente
commented
1 year ago Hello, just a heads up that the next release will change the chat command from /[macro name] to /amacro [macro name] to avoid potential conflicts with systems and other modules.
folken88
commented
1 year ago DOH Ok. That's a lot of updating, thank you! Is FVTT itself going to support /macro calls now? I asked atropos for that ages ago so I could quit pestering you, lol...
-T
On Sun, Nov 13, 2022 at 3:08 PM Matheus Clemente @.***> wrote:
Hello, just a heads up that the next release will change the chat command from /[macro name] to /amacro [macro name] to avoid potential conflicts with systems and other modules.
— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros/issues/30#issuecomment-1312822485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTEZZFLYOMHHFJL6O2LWIFKEPANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-advanced-macros/issues/30/1312822485@ github.com>
mclemente
commented
1 year ago /macro is in V10, I'm not sure when it was added, though. It was there in the last 2 versions of V10. It works the same way (/macro [macro name]).
They don't support arguments, though. So it might not work for all your macros, but you could consider dropping Advanced Macros if your macros don't take arguments at all.
folken88
commented
1 year ago Finally got to try pf1/v11 and macros appear to be completely broken. Is there any plan to return the /blarb simple style of macro use via your mod or others? Is it possible in v11?
On Sun, Nov 13, 2022 at 8:13 PM Matheus Clemente @.***> wrote:
/macro is in V10, I'm not sure when it was added, though. It was there in the last 2 versions of V10. It works the same way (/macro [macro name]). They don't support arguments, though. So it might not work for all your macros, but you could consider dropping Advanced Macros if your macros don't take arguments at all.
— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros/issues/30#issuecomment-1312947573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTBIAOSDBWHAZSH6LMDWIGN5XANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-advanced-macros/issues/30/1312947573@ github.com>
mclemente
commented
1 year ago Have you updated Advanced Macros after upgrading to V11? The V10 version breaks on V11, so you need to update the module to its latest version.
V11 also introduced its own macro arguments, which is a bit different from what Advanced Macros used, so you might need to fix some macros.
With that said, the "/blarb" feature is still there, though.
folken88
commented
1 year ago Hrmm! I thought i did, but I certainly could have missed it! Thanks for your encouraging answer!
I'll do some testing on a local install!
T
On Mon, Jul 17, 2023 at 3:12 PM Matheus Clemente @.***> wrote:
Have you updated Advanced Macros after upgrading to V11? The V10 version breaks on V11, so you need to update the module to its latest version.
V11 also introduced its own macro arguments, which is a bit different from what Advanced Macros used, so you might need to fix some macros.
With that said, the "/blarb" feature is still there, though.
— Reply to this email directly, view it on GitHub https://github.com/mclemente/fvtt-advanced-macros/issues/30#issuecomment-1638801942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTDAW5IEPO4FEBRZWGDXQWMB7ANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: @.***>
folken88
commented
1 year ago Oof I'm so sorry I bothered you! I see you've put a check-box in the mod config that gets my people where they need to be. Thank you for that, and thank you for taking the time to help us as you have a dozen times already!
-T
On Mon, Jul 17, 2023 at 3:32 PM Tobias Merriman @.***> wrote:
Hrmm! I thought i did, but I certainly could have missed it! Thanks for your encouraging answer!
I'll do some testing on a local install!
T
On Mon, Jul 17, 2023 at 3:12 PM Matheus Clemente @.***> wrote:
Have you updated Advanced Macros after upgrading to V11? The V10 version breaks on V11, so you need to update the module to its latest version.
V11 also introduced its own macro arguments, which is a bit different from what Advanced Macros used, so you might need to fix some macros.
With that said, the "/blarb" feature is still there, though.
— Reply to this email directly, view it on GitHub https://github.com/mclemente/fvtt-advanced-macros/issues/30#issuecomment-1638801942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUNKTDAW5IEPO4FEBRZWGDXQWMB7ANCNFSM5ZIZWTKQ . You are receiving this because you authored the thread.Message ID: @.***>
Works in starfinder, but no longer in pf1. They blame the module so I'm reporting it here, but their update broke this so?
I use dozens of macros, called by typing their /name in chat, to facilitate blind players controlling their characters. They're unable to play when adv-macros is down.
The error in the console is: "foundry.js:58074 Uncaught (in promise) Error: /per is not a valid chat message command. [No packages detected] at ChatLog.processMessage (foundry.js:58074:40) at ChatLog._onChatKeyDown (foundry.js:58356:19) at HTMLTextAreaElement.dispatch (jquery.min.js:2:43064) at v.handle (jquery.min.js:2:41048)"