search

mclemente / fvtt-advanced-macros

Use handlebars templating, recursive macro calls and call macros with arguments or directly from chat.
MIT License
15 stars 9 forks source link

Issue with Blood Lords Premium Module #50

Closed Craftzero closed 1 year ago

Craftzero commented 1 year ago

The PF2e Premium Modules Blood Lords use a handful of Macros for various things (changing the landing page, activating ambience, etc). With Advanced Macros active, these macros don't seem to work. Here is the error:

localhost-1669155632195.log

mclemente commented 1 year ago

Hm, I know what's causing this but I don't understand why it is happening, unless Blood Lords replaces/wraps TextEditor._createContentLink. That said, I can fix the error breaking macro execution, but I can't guarantee macros like it will run with arguments. They will run, but not with arguments. I doubt any of them have arguments, though, since that's a recent change from Advanced Macros. I've released a new version that might fix the issue. Check it out and tell me if anything else is wrong.

Craftzero commented 1 year ago

All the macros that appear broken do in fact have spaces in the titles!

mclemente commented 1 year ago

No, I was wrong about space in names, it wasn't an issue at all. I'm just not sure what could've triggered those errors

mclemente commented 1 year ago

Hey, was this issue resolved with the changes on v1.19.3? I can't test stuff from premium content on my own.

mclemente commented 1 year ago

Foundry V11 will overhaul how macro calls are made, but this was an issue related to its journal feature, so I'm wondering if it is still broken on V11.