mclemente / fvtt-advanced-macros

Use handlebars templating, recursive macro calls and call macros with arguments or directly from chat.
MIT License
15 stars 9 forks source link

[PF2] Concealed condition error #66

Closed Adooooorra closed 1 year ago

Adooooorra commented 1 year ago

I'm running Foundry v. 10.291 and PF2 version 4.12.8. When I apply the concealed condition to any token, I get error messages and the conditions no longer appear in the top-right corner of the map. This only happens with the concealed condition. Here is an image of the bug.

Reswob conditions

Here is an image of the console error messages.

FVTT debug

It sounds like there is a formatting error in the macro itself, but I don't know enough to identify or fix that. Here is the text of the macro:

const [token] = pf2eAnimations.macroHelpers(args) const tokenMagic = game.settings.get("pf2e-jb2a-macros", "tmfx")

if (!args.length) args[0] = tokenMagic ? TokenMagic.hasFilterId(token, "Concealed") ? "off" : "on" : null

if (TokenMagic.hasFilterId(token, "Blur") || TokenMagic.hasFilterId(token, "Heat Haze")) return;

const params = [{ filterType: "xfire", filterId: "Concealed", time: 0, color: 0xBBDDEE, blend: 1, amplitude: 1, dispersion: 0, chromatic: false, scaleX: 1, scaleY: 1, inlay: false, animated : { time : { active: true, speed: -0.0015, animType: "move" } } }];

pf2eAnimations.applyTokenMagic(args, params);

mclemente commented 1 year ago

Conditions no longer appearing was an issue on that version of PF2e and was fixed 2 days ago https://github.com/foundryvtt/pf2e/releases/tag/4.12.9

Activate Token Magic FX.

This isn't an Advancced Macros issue.

Adooooorra commented 1 year ago

Oh thank god. I can't believe I missed that.