mclemente / fvtt-condition-lab-triggler

Condition Lab & Triggler module for Foundry Virtual Tabletop
GNU General Public License v3.0
6 stars 4 forks source link

Module Conflict w/ Status Halo - CLT doesn't behave the same as CUB did. #10

Closed tjlanza closed 11 months ago

tjlanza commented 1 year ago

Describe the bug Under v10.303, the predecessor module, Combat Utility Belt v1.10.4 was compatible with Status Halo v0.1.1 but under v11.305, CLT v1.4.1 does not play nicely.

To Reproduce Install both modules.

Expected behavior Status Halo's icon placement should override CLT's.

Screenshots v10 & CUB image

v11 & CLT - You can see that the reorganization doesn't take place fully, but parts of it do. There's a visible offset in the icon placement. image

libWrapper identifies there's a potential conflict, but nothing actually appears in the console that corresponds. image

Environment Info (please complete the following information):

Additional context Add any other context about the problem here.

mclemente commented 11 months ago

It's Status Halo that is breaking this. Any module/system that directly wraps a method will conflict with libWrapper.

It worked with CUB because it overwrote Token.prototype._refreshEffects and then Status Halo was able to call it.

The best I can do is to make it so the icon size setting has no effect if the Status Halo is enabled.