mclemente / fvtt-condition-lab-triggler

Condition Lab & Triggler module for Foundry Virtual Tabletop
GNU General Public License v3.0
6 stars 4 forks source link

Conflict with Monk little details (condition name dissapear) #14

Closed Fridan99 closed 1 year ago

Fridan99 commented 1 year ago

Describe the bug the names in the conditions are not visible

To Reproduce Steps to reproduce the behavior:

  1. Install Monk Little details, Conditionlab & Trigglers, dnd5e system, and Foundry v11.307
  2. Click on 'the status effect on any token in the canvas'
  3. See error: you can't see the name of the status condition "Blinded, charmed, ......."

Expected behavior See the conditions name.

Screenshots 1 11

Environment Info (please complete the following information):

Dnd5e system 2.3.0

Foundry v11.307

Monk little details 11.04

Contitionlab & Trigglers 1.4.1

Additional context There is an open issue on Monk Little Details....

https://github.com/ironmonk88/monks-little-details/issues/273

IggydB commented 1 year ago

I played around with enabling and disabling some items and found that this appears to be due to the setting in Condition Lab that removes the Default conditions from the Hud.

image

It isn't all good news though, since disabling this setting adds those back in but doesn't remove the ones added by Condition lab, therefore Little Details is unable to add the naming to status effects it doesn't touch/own.

image

Would like to see some collaboration for integration between these two in the future as for the life of me I cannot get DFreds Convenient effects to properly do a stacking buff, therefore Condition lab is the only option I have and I'd like to see those names.

KJTailor commented 1 year ago

Here to +1 the issue, if possible, please. Both are great modules and I wouldn't want to miss one or the other.

MythicalRollers commented 1 year ago

I was able to reproduce this issue and resolve it with one caveat that I have yet to see anyone else mention. For me. Dfred Convenient Effects was also adding to the list. I have this only because d&dbeyond importer wants it, I do not actively use it. I set it to None under status effects in the settings for it, and my list is visible again. So for me the issue was related to Monk's, Dfreds, and Condition Lab & Triggler.

KJTailor commented 1 year ago

I wrote kind of a collation of the issue to DFred hoping they maybe can do something about it.

mclemente commented 1 year ago

Does this issue persists on MLD v6.0? Just tried to fix this issue and it is working fine right now.

KJTailor commented 1 year ago

I finally got around to check and found, indeed it is not persisting anymore!

Fridan99 commented 1 year ago

It seems to be solved. Thank you, I close the thread