mclemente / fvtt-condition-lab-triggler

Condition Lab & Triggler module for Foundry Virtual Tabletop
GNU General Public License v3.0
6 stars 4 forks source link

Mark Invisible option is only allowed on a single condition. #21

Open Oryan77 opened 11 months ago

Oryan77 commented 11 months ago

Describe the bug When checking "Mark Invisible" in the Option Configuration within Condition Lab for a new condition, the "Mark Invisible" option will uncheck on any other condition that originally had the option checked.

To Reproduce Steps to reproduce the behavior:

  1. Go to Condition Lab
  2. Create new condition
  3. Click Options for that condition
  4. Check "Mark Invisible" and save
  5. Create another new condition
  6. Click Options for that condition
  7. Check "Mark Invisible" and save
  8. Click Options on the 1st new condition created
  9. "Mark Invisible" is now uncheked

Expected behavior "Mark Invisible" should be checked for multiple conditions if needed. Example conditions that would all benefit from marking a token in the invisible state would be hide, invisibility, greater invisibility, hide from monsters, etc.

Environment Info (please complete the following information):

mclemente commented 11 months ago

There is a lot of code to guarantee there's only one condition for a special status effect here. The dialog that pops up is supposed to tell you that (I've fixed the string for 1.4.6), so I guess there is a limitation somewhere. I'm not sure since I didn't wrote it, it was there when I took over the project.