search

mclemente / fvtt-dice-tray

A FoundryVTT module that adds a Dice Tray and a Dice Calculator to the chat tab.
MIT License
5 stars 8 forks source link

Extra buttons (fortune/misfortune) not rendering in PF2e v5.11+ #14

Closed tdhsmith closed 10 months ago

tdhsmith commented 10 months ago

A change in the global CSS in the PF2e system causes the hidden attribute to have style display: none !important, which jQuery's show() function won't override.

I filed a pretty long bug report there (https://github.com/foundryvtt/pf2e/issues/12869), but IMO it's not really an incorrect approach on their end and would probably take a lot of effort to "fix".

Comparatively I'd suggest that this module could change approach slightly, for example just a one line swap in TemplateDiceMap._createExtraButtons to:

html.find("#dice-tray-math").removeAttr("hidden");

...would be sufficient to make them render again.

mclemente commented 10 months ago

I've applied your suggestion. Thank you