search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
40 stars 48 forks source link

System support for GURPS 4e -- Does not appear to work as per Closed Item #218 #229

Closed TheFabulousIronChef closed 2 years ago

TheFabulousIronChef commented 2 years ago

Describe the bug I cannot get the module to display text that shows it translated for the player who understands the language being used no matter what I do with any players on their character sheets. That is so even if I change the languages in the import file or change them from within Foundry.

To Reproduce This happens when I used custom languages or the standard with GURPS Game Aid. If I have an advantage on the Character sheet as Language (Ancient) or Language: Ancient, when I type a statement as the GM with "Ancient" selected as the language, no one can understand it, even those who speak Ancient as per their character sheets. Likewise, they do not have a drop-down list for anything other than common. The first screenshot is the GM view, the second screenshot is the player view.

Expected behavior It should translate the words spoken for the player who knows that language.

Screenshots image image image image image image

Additional context Add any other context about the problem here.

TheFabulousIronChef commented 2 years ago

Also, it's kind of strange that "Default Alphabet" and "Common" want a font, but I just left them as is and didn't change anything, and they display correctly. So that's not an issue, just a little odd that there is no ability to select "default" or something like that.

TheFabulousIronChef commented 2 years ago

I also tried adding two advantages, one called "Ancient," and the other called "Language" and "Ancient" as the subcategory. Didn't make a difference; still doesn't work.

image

TheFabulousIronChef commented 2 years ago

I also tried putting Language (Ancient) in notes, as a skill, as equipment, etc. -- still doesn't work.

mclemente commented 2 years ago

I forgot to reply to this, but I couldn't reproduce this. Setting an advantage like Language (Ancient) worked fine for me.

TheFabulousIronChef commented 2 years ago

Apparently it does work if the advantage is "top level," but not if it is in a container (folder). I believe Chris Normand (one of authors of GGA) was going to submit a pull request or something for this.

On Thu, Apr 21, 2022 at 3:51 AM Matheus Clemente @.***> wrote:

I forgot to reply to this, but I couldn't reproduce this. Setting an advantage like Language (Ancient) worked fine for me.

— Reply to this email directly, view it on GitHub https://github.com/League-of-Foundry-Developers/fvtt-module-polyglot/issues/229#issuecomment-1104832508, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDN5UXCLDBW7L4BEIUB4PTVGECHPANCNFSM5TMC6PLA . You are receiving this because you authored the thread.Message ID: <League-of-Foundry-Developers/fvtt-module-polyglot/issues/229/1104832508@ github.com>

crnormand commented 2 years ago

Yes, I am working on one now. I just needed to know if there was a "level" of comprehension that I should set, along with the list of known_languages and literate_languages (there is not).

The GURPS Game Aid can accept data from GCA4, GCA5 and GCS, and of course, each one indicates "languages" slightly differently, so the code is slightly more complex than a single regex, sadly.

crnormand commented 2 years ago

Fixed with: https://github.com/League-of-Foundry-Developers/fvtt-module-polyglot/pull/234